Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging as to why resume upload failed (Issue #468) #470

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

abraunegg
Copy link
Owner

  • Log 'why' the resume upload failed
  • Remove the 'resume_upload' as it is invalid & contains bad data

* Log 'why' the resume upload failed
* Remove the 'resume_upload' as it is invalid & contains bad data
@abraunegg abraunegg added this to the v2.3.3 milestone Apr 15, 2019
@abraunegg abraunegg requested a review from norbusan April 15, 2019 00:33
@abraunegg
Copy link
Owner Author

@norbusan
To test that is is working, the following can be added before line 87:

					writeln("making fake response");
					
					response = [
							"id": JSONValue("asdfasdf"),
							"cTag": JSONValue("asdfasdf")
							];
					
					// do we have a valid response from OneDrive?

@abraunegg abraunegg merged commit ea26e4d into master Apr 15, 2019
@abraunegg abraunegg deleted the update-issue-468-fix branch April 15, 2019 00:56
@lock
Copy link

lock bot commented May 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants