Implement option --display-config (Issue #100)

[abraunegg]

• Implement --display-config to show the application configuration without actually performing a sync or application init

[abraunegg]

Output when run:

./onedrive --display-config
Config path                         = /home/alex/.config/onedrive
Config file found in config path    = false
Config option 'sync_dir'            = /home/alex/OneDrive
Config option 'skip_file'           = ~*
Config option 'skip_symlinks'       = false
Config option 'monitor_interval'    = 45
Config option 'log_dir'             = /var/log/onedrive/
Selective sync configured           = false

Testing of CLI switches:

./onedrive --display-config --skip-symlinks --confdir '~/odconfig/'
Config path                         = /home/alex/odconfig/
Config file found in config path    = true
Config option 'sync_dir'            = /home/alex/OneDriveALT
Config option 'skip_file'           = ~*
Config option 'skip_symlinks'       = true
Config option 'monitor_interval'    = 90
Config option 'log_dir'             = /var/log/onedrive/
Config option 'drive_id'            = <redacted>
Selective sync configured           = false

[norbusan]

The config crash needs fixing, the rest is fine, but see my comment. Thanks for implementing this!

[norbusan]

Thanks, compile and run tested here.

[abraunegg]

Are there any further options / config options we should print out when this flag is used?

• no upload-only / download-only .. indicate a full bi-directional sync
• upload validation
• remote delete handling

Thoughts?

[norbusan]

Since this is an exclusive option and not pairable with --synchronize or --monitor, I think only the options configurable in the config file should be shown. All other options are set during sync/monitor run on the command line.

OTOH, it might be worth haveing onedrive --display-config ..otheroption.. --synchronize display the full set of configured stuff (config file and cmd line options) before starting the sync operation. But that can wait for another release maybe?

[abraunegg]

OTOH, it might be worth haveing onedrive --display-config ..otheroption.. --synchronize display the full set of configured stuff (config file and cmd line options) before starting the sync operation. But that can wait for another release maybe?

I agree - potentially beneficial when running the application as well, rather than exit & be able to use / display at the start before running. Would help with future diagnostic situations as well.

This issue (#293) also highlights another 'hidden' problem - that is, invalid 'config' options due to spelling or otherwise.

Potentially need to add in to always check the 'config' file if present to ensure that all options that are contained within the file are:

• spelt correctly
• valid options by name or otherwise

[adudek]

It would be even better solution to parse config into JSON format, and give ability to use this output as config source for "semi-automatic" setup with --use-config='file.json'
It then could be used as debug data file (when submitting issue) and would be easy to validate with JSON schema

[norbusan]

I sent a pull request concerning the validation of config file, and I will look into the JSON stuff. Let us discuss this in a different issue.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.