allow starting offline in monitor mode #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbusan
force-pushed
the
issue257-start-offline
branch
from
873166e to
de4d52e
Compare
abraunegg
previously requested changes
Dec 3, 2018
norbusan
force-pushed
the
issue257-start-offline
branch
from
de4d52e to
81323c3
Compare
|
I added the missing shutdown, and rebased on master |
always call initSyncEngine during regular syncs, this will call the SyncEngine init routine which caches the state, thus a quasi no-op.
norbusan
force-pushed
the
issue257-start-offline
branch
from
81323c3 to
a515fdf
Compare
abraunegg
approved these changes
Dec 4, 2018
|
Thanks a lot! |
3 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests allows for startup of onedrive in monitor mode while the computer is offline. The pull request is split into three commits to make the changes more understandable.
The first commit ensures that the SyncEngine's init function can be called repeatedly by caching the success state in a private boolean.
The second commit factors out the initialization of the sync engine and handling of exceptions into a separate function that will be reused later on.
The last commit changes the sync routine of the monitor mode that during the start the sync engine is initialized via the previously factored out function. In case it is ready, this is a (quasi) noop. The commit also reduces the double try/catch on CurlException in the sync routine (formerly used to check whether online). We can later add better logging to provide feedback what might have been the error.
With these changes onedrive can start while being offline, and start syncing as soon as the connection becomes available.