Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use constants for message encoding strings #77

Merged
merged 2 commits into from
Sep 4, 2018
Merged

use constants for message encoding strings #77

merged 2 commits into from
Sep 4, 2018

Conversation

gernest
Copy link
Contributor

@gernest gernest commented Sep 4, 2018

No description provided.

@ORBAT
Copy link
Contributor

ORBAT commented Sep 4, 2018

"utf-8" and a couple of other magic string literals are also used in Message.EncodeData and DecodeData:

/~https://github.com/ably/ably-go/blob/develop/ably/proto/message.go#L39-L88

@gernest gernest changed the title fix message encoding string to utf-8 use constants for message encoding strings Sep 4, 2018
ORBAT
ORBAT approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@ORBAT ORBAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you

@ORBAT ORBAT merged commit 8b8c1ad into ably:develop Sep 4, 2018
@gernest gernest deleted the fix-encoding-on-publish branch September 4, 2018 13:08
@ORBAT ORBAT mentioned this pull request Sep 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ORBAT ORBAT ORBAT approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gernest @ORBAT