Use new msgpack package #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions are used to encode and decode msgpack using github.com/ugorji/go/codec library
Use []byte instead of string, codec seems to support []byte and defaults to it for strings
ORBAT
suggested changes
Aug 28, 2018
ably/realtime_client_test.go
Outdated
| @@ -90,7 +90,7 @@ func checkUnique(ch chan string, typ string, n int) error { | |||
| } | |||
|
|
|||
| func TestRealtimeClient_50clients(t *testing.T) { | |||
There was a problem hiding this comment.
Might as well rename the test
| "bytes" | ||
| "io" | ||
|
|
||
| "github.com/ugorji/go/codec" |
There was a problem hiding this comment.
No, not in this PR. I plan to make Godep directory go away by the time we integrate the integration branch to develop and use the new go module to manage dependencies.
But that work will be done later.
|
As a note, this PR was necessary because the original msgpack decoder would only decode double values to a |
ORBAT
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces github.com/ugorji/go/codec as mspack encoder/decoder