auth: latest spec additions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames testutil to ablytest and moves all helper types from helpers_test.go file.
- add tests for RSA8c
Add 1s margin for times received from Ably servers.
The TokenAuth test sometimes fails with:
--- FAIL: TestAuth_TokenAuth (4.31s)
auth_test.go:156: want t=2015-10-29 14:58:58.275 +0100 CET to be
within [2015-10-29 14:58:58.560058554 +0100 CET, 2015-10-29
14:58:58.984524906 +0100 CET] time span
Especially on flaky internet connection.
- reduce size of proto.ProtocolMessage from 264B back to 200B
- add ABLY_LOGLEVEL env for testing - drop Protocol field - rename UseBinaryProtocol to NoBinaryProtocol (default is to use binary) - minor change: store ClientOptions only once, add log helper to all types
|
This looks great @rjeczalik 👍 |
|
@mattheworiordan @lmars @kouno Ok to merge? |
|
Globally, looks good. 👍 |
|
LGTM |
|
I've added some comments @rjeczalik but this looks great |
rjeczalik
force-pushed
the
devel
branch
2 times, most recently
from
81e987e to
c421cbd
Compare
|
Hey @mattheworiordan @kouno, I've addressed all. Is there's something more to do? |
mattheworiordan
added a commit
that referenced
this pull request
Nov 18, 2015
auth: latest spec additions
|
Thanks @rjeczalik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This CL:
clientIddue to missingomitemptytag inTokenRequeststruct definition)/cc @mattheworiordan @lmars @kouno