Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ARTRealtimeChannel.publish thread-safe #929

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Make ARTRealtimeChannel.publish thread-safe #929

merged 2 commits into from
Dec 9, 2019

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Dec 8, 2019

This was somehow left behind as part of the whole #620 effort.

Fixes #926.

@tcard
Make ARTRealtimeChannel.publish thread-safe.
5e23986 
This was somehow left behind as part of the whole #620 effort.

Fixes #926.
@tcard tcard requested a review from QuintinWillison December 8, 2019 10:35
@tcard tcard self-assigned this Dec 8, 2019
QuintinWillison
QuintinWillison approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 ... but, 👍🏼

@tcard
ARTRealtimeChannel.publish: dispatch_sync instead of async.
ef2700a 
Tests rely on this to observe the effects right after the method is
called.
@tcard tcard merged commit 10e513e into develop Dec 9, 2019
@tcard tcard deleted the 926-queued-msg-order branch December 9, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

Assignees

@tcard tcard

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queuing messages before attach can lead to out-of-order publishing
2 participants
@tcard @QuintinWillison