Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: update the release process #906

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Conversation

ricardopereira
Copy link
Contributor

Add a note in the release process to test the lib integration in Xcode projects.

README.md Outdated
* Generate the prebuilt framework for Carthage (`(carthage build --no-skip-current && carthage archive Ably)`) and attach the zip file to the release.
* Release an update for CocoaPods: `pod lib lint && pod trunk push Ably.podspec`.
* Generate the prebuilt framework for Carthage (`carthage build --no-skip-current --archive`) and attach the zip file to the release.
* Test the integration of the library in a Xcode project using Carthage and CocoaPods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it obvious what to do for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, to Cocoa developers, I think yes. But I can add more details saying to use the installation guide. Something like:

  • Test the integration of the library in a Xcode project with Carthage and CocoaPods using the installation guide.

@paddybyers Better?

Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@paddybyers paddybyers merged commit 8a922ed into develop Oct 5, 2019
@ricardopereira ricardopereira deleted the readme-carthage-integration branch October 5, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants