Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KSCrash and SocketRocket #858

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Update KSCrash and SocketRocket #858

merged 2 commits into from
Jun 11, 2019

Conversation

ricardopereira
Copy link
Contributor

This fixes #840 and #846.

KSCrash:

SocketRocket:

mattheworiordan
mattheworiordan approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

paddybyers
paddybyers approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ricardopereira ricardopereira merged commit cd7cb1a into develop Jun 11, 2019
@ricardopereira ricardopereira deleted the fix-lexical-issues branch June 11, 2019 08:13
@ricardopereira ricardopereira mentioned this pull request Jun 11, 2019
Closed
@ricardopereira ricardopereira mentioned this pull request Jun 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworiordan mattheworiordan mattheworiordan approved these changes

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lexical or Preprocessor Issue: 'SRWebSocket.h' file not found
3 participants
@ricardopereira @mattheworiordan @paddybyers