Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reattaching channels in compliance with RTN15c3 #1172

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Reattaching channels in compliance with RTN15c3 #1172

merged 4 commits into from
Aug 31, 2021

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Aug 26, 2021

Closes #847

QuintinWillison
QuintinWillison approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not manually verified your logic against the spec, however the change looks simple enough so I'll trust your implementation. 😄

@maratal
Copy link
Collaborator Author

maratal commented Aug 27, 2021

I've not manually verified your logic against the spec, however the change looks simple enough so I'll trust your implementation. 😄

It just assures that #835 (comment)

@lukasz-szyszkowski lukasz-szyszkowski merged commit 32a6173 into main Aug 31, 2021
@lukasz-szyszkowski lukasz-szyszkowski deleted the fix/847-RTN15c3-compliance branch August 31, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@lukasz-szyszkowski lukasz-szyszkowski lukasz-szyszkowski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check RTN15c3 implementation
3 participants
@maratal @QuintinWillison @lukasz-szyszkowski