Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix of RSH3a2a1 implementation when the clientId doesn't change #1107

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Fix of RSH3a2a1 implementation when the clientId doesn't change #1107

merged 2 commits into from
Mar 25, 2021

Conversation

ricardopereira
Copy link
Contributor

cruickshankpg
cruickshankpg approved these changes Mar 19, 2021
View reviewed changes
Copy link

@cruickshankpg cruickshankpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM

@ricardopereira ricardopereira merged commit 6e4ce0a into main Mar 25, 2021
@ricardopereira ricardopereira deleted the fix/RSH3a2a1 branch March 25, 2021 16:39
@QuintinWillison QuintinWillison added the bug Something isn't working. It's clear that this does need to be fixed. label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cruickshankpg cruickshankpg cruickshankpg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardopereira @cruickshankpg @QuintinWillison