Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes close connection emits detached event on an already detached channel #1091

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Fixes close connection emits detached event on an already detached channel #1091

merged 3 commits into from
Apr 27, 2021

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira ricardopereira marked this pull request as ready for review November 20, 2020 10:46
@ricardopereira
Copy link
Contributor Author

Screenshot 2020-11-20 at 09 14 21

@QuintinWillison
Copy link
Contributor

It looks like the failing checks are due to flakey tests or perhaps network issues:

  • RealtimeClient__Auth_authorize_should_upgrade_the_connection_with_current_token__authorize_call_should_complete_with_an_error_if_the_connection_moves_to_the_CLOSED_state
  • Connection__connection_failures_once_CONNECTED__ACK_and_NACK_responses_for_published_messages_can_only_ever_be_received_on_the_transport_connection_on_which_those_messages_were_sent

I am, therefore, happy to land this pull request despite those failures. We're keen to get a release out.

@QuintinWillison QuintinWillison merged commit 48e50d1 into main Apr 27, 2021
@QuintinWillison QuintinWillison deleted the fix/1088 branch April 27, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @QuintinWillison