Initial implementation of AssetSubscriber class #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavalerov
reviewed
Dec 7, 2020
QuintinWillison
approved these changes
Dec 7, 2020
.github/workflows/actions.yml
Outdated
| @@ -0,0 +1,20 @@ | |||
| name: ably-asset-tracking-js CI | |||
There was a problem hiding this comment.
For what it's worth, given name is optional at the root of these files, I opted to leave it out entirely and use the file name to convey purpose (e.g. here (check) and here (assemble)). It's repetition, in my opinion.
As such, I would be tempted to rename this file to fit purpose (is this equivalent to our Android check?).
Also, TIL, npm-ci. 😁
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Might it be worth also having an .editorconfig file also?
We have one in the Android repository.
| @@ -0,0 +1,32 @@ | |||
| ### Usage | |||
There was a problem hiding this comment.
I think perhaps a top-level (##, H2) header to intro the repository would be nice from outset.
|
@owenpearson can we merge this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely a direct clone of the Kotlin version. The public API is presented by example in README.md - the only major difference here is that the
AssetSubscriberclass uses an options pattern rather than a builder pattern, although this can easily be changed if needed.