Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Black GitHub action to the official working version #1337

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

tburrows13
Copy link
Collaborator

@tburrows13 tburrows13 commented Oct 8, 2020

For the last couple of days, our black GitHub action has been failing (/~https://github.com/Zulko/moviepy/runs/1222088083). This PR changes the action to one from the official black repo (/~https://github.com/psf/black/blob/master/Dockerfile). Note that it does not allow customisation of arguments, so without specifying Python 3.6 it defaults to "per-file auto-detection". I've tested this and no matter what version of Python 3 I specify, nothing changes in black's output. We'll continue to recommend that contributors use -t py36, so in the unlikely event that the GH action lets something incompatible with Python 3.6 through, someone else should catch it very quickly.

Issue reported to the original action: lgeiger/black-action#12
Feature request to official action: psf/black#1751

@tburrows13 tburrows13 added the tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. label Oct 8, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.861% when pulling 0fa188e on tburrows13:fix-black-action into 873530e on Zulko:master.

@tburrows13 tburrows13 merged commit b23cc69 into Zulko:master Oct 8, 2020
@tburrows13 tburrows13 mentioned this pull request Oct 9, 2020
@tburrows13 tburrows13 deleted the fix-black-action branch October 18, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants