Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coreader function to VideoFileClip #1332

Merged
merged 4 commits into from
Oct 8, 2020
Merged

Add coreader function to VideoFileClip #1332

merged 4 commits into from
Oct 8, 2020

Conversation

jkolbly
Copy link
Contributor

@jkolbly jkolbly commented Oct 5, 2020 •
edited by tburrows13
Loading

Tested on code snippet from issue #915. Without this fix, snippet raises an AttributeError because VideoFileClip has no attribute coreader. This fix should close #915.

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have formatted my code using black -t py36

@coveralls
Copy link

coveralls commented Oct 5, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 67.849% when pulling 68582cd on ToxicOverload:VideoCoreader into 0e4bf6d on Zulko:master.

@tburrows13
Copy link
Collaborator

Thanks for the pull request, this looks perfect!

@tburrows13 tburrows13 self-requested a review October 6, 2020 17:12
@jkolbly jkolbly closed this Oct 7, 2020
@jkolbly jkolbly deleted the VideoCoreader branch October 7, 2020 00:31
@jkolbly jkolbly restored the VideoCoreader branch October 7, 2020 00:33
@jkolbly jkolbly deleted the VideoCoreader branch October 7, 2020 00:33
@tburrows13
Copy link
Collaborator

tburrows13 commented Oct 7, 2020 •
edited
Loading

Sorry, I don’t understand what you’ve done here? Your fix for #1307 should have been in a separate branch and PR, and now you’ve deleted this branch I can’t merge the coreader addition.

@jkolbly jkolbly restored the VideoCoreader branch October 7, 2020 01:17
@jkolbly
Revert "Fix Zulko#1307"
68582cd 
This reverts commit 22b47aa. It was pushed to the wrong branch.
@jkolbly jkolbly reopened this Oct 7, 2020
@jkolbly
Copy link
Contributor Author

jkolbly commented Oct 7, 2020

I'm so sorry! This is basically my first time using Git for a collaborative project, so I'm learning. Hopefully it's fixed now? I hope this didn't cause too much trouble.

@tburrows13
Copy link
Collaborator

tburrows13 commented Oct 7, 2020 •
edited
Loading

No worries, it looks fine now. Git/Github can be hard at first! All the commits from this PR will be squashed into one when I merge it so it won't clutter up the commit history :)

For some reason the code format check has stopped working. Don't worry about that, its not your fault.

@tburrows13 tburrows13 merged commit 21fff15 into Zulko:master Oct 8, 2020
@tburrows13 tburrows13 added the feature New addition to the API i.e. a new class, method or parameter. label Oct 8, 2020
@mondeja mondeja mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tburrows13 tburrows13 tburrows13 approved these changes

Assignees
No one assigned
Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'VideoFileClip' object has no attribute 'coreader'
3 participants
@jkolbly @coveralls @tburrows13