Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile to modify policy.xml in-place #1304

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

TrippleCCC
Copy link
Contributor

@TrippleCCC TrippleCCC commented Aug 24, 2020

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

The last line in the Dockerfile currently removes all content from the policy.xml file since the file cannot be read from and simultaneously written too. This fix edits the file in place using sed -i.

This bug can be reproduced by building the docker image and then running docker run (tagname) cat /etc/ImageMagick-6/policy.xml

@coveralls
Copy link

coveralls commented Aug 24, 2020

Coverage Status

Coverage remained the same at 67.544% when pulling 1c9eaaf on TrippleCCC:docker-bug into 79b2c1d on Zulko:master.

@tburrows13
Copy link
Collaborator

Thanks for spotting this. I'll merge it now, although I'm still hoping that we can get rid of ImageMagick entirely soon!

@tburrows13 tburrows13 merged commit c8d02de into Zulko:master Sep 21, 2020
@tburrows13 tburrows13 added docker Anything to do with running MoviePy in Docker containers. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. labels Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Anything to do with running MoviePy in Docker containers. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants