Loop effect needs fixing

[tburrows13]

You can see in test_loop() that loop is not quite working as some tests are skipped or else they would cause the tests to fail. To close this issue you need to do the following

• Try running the tests that are currently broken
• Fix loop so that the tests can run (or convince me that the tests are wrong :) )
• Add some new tests using BitmapClip (in the vein of test_freeze() to test for frame-perfect looping

Feel free to comment here or on GitHub if you need some help.
This is a specific case of #1355.

[ParikhNand]

@tburrows13
Could you please assign this issue to me?

[RealA10N]

#1372 May be related & helpful :D

[julienbeisel]

Hi @tburrows13,

I'm using Moviepy a lot and I'd like to contribute.

Maybe I'm wrong but I think the loop effect is still not working properly:

moviepy/moviepy/video/fx/loop.py

Lines 7 to 27 in 6ab3efb

	def loop(clip, n=None, duration=None):
	"""
	Returns a clip that plays the current clip in an infinite loop.
	Ideal for clips coming from gifs.
	Parameters
	------------
	n
	Number of times the clip should be played. If `None` the
	the clip will loop indefinitely (i.e. with no set duration).
	duration
	Total duration of the clip. Can be specified instead of n.
	"""
	previous_duration = clip.duration
	clip = clip.time_transform(lambda t: t % previous_duration)
	if n:
	duration = n * previous_duration
	if duration:
	clip = clip.with_duration(duration)
	return clip

If n is set to a value but duration is set to None, the clip won't be updated. That might be one of the reasons the tests are broken.

Can I try to fix it or somebody else is already working on it ?

[tburrows13]

Hi @julienbeisel, I can't replicate that problem with the latest version in master (after #1373 is applied). Is it still an issue for you?