Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rolldown plugin support #46

Merged
merged 3 commits into from
Feb 24, 2025
Merged

feat: add rolldown plugin support #46

merged 3 commits into from
Feb 24, 2025

Conversation

Nsttt
Copy link
Member

@Nsttt Nsttt commented Feb 21, 2025

What's added in this PR?

Add rolldown plugin support to Zephyr.

https://nestor-lopez-555-rolldown-react-hmr-test-nstlopez-6e9969581-ze.zephyrcloud.app/

Screenshots

CleanShot 2025-02-21 at 23 05 06

What are the steps to test this PR?

  1. Install repository dependencies and build all plugins.
  2. Go to examples/rolldown-react and try to pnpm build. It should deploy to Zephyr.

Documentation update for this PR (if applicable)?

Add documentation if how the application will behave differently than previous state. Copy paste your PR in zephyr-documentation PR link here.

(Optional) What's left to be done for this PR?

(Optional) What's the potential risk and how to mitigate it?

(Required) Pre-PR/Merge checklist

  • I have added/updated/opened a PR to documentation to cover this new behavior
  • I have added an explanation of my changes
  • I have written new tests (if applicable)
  • I have tested this locally (standing from a first time user point of view, never touch this app before)
  • I have/will run tests, or ask for help to add test

@Nsttt Nsttt self-assigned this Feb 21, 2025
Copy link

nx-cloud bot commented Feb 21, 2025

View your CI Pipeline Execution ↗ for commit 76b8a34.

Command Status Duration Result
nx affected -t test ✅ Succeeded 2s View ↗
nx affected -t lint ✅ Succeeded 4s View ↗
nx run-many -t build --all --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-21 22:18:31 UTC

Copy link
Contributor

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good to merge, but needs:

  • tests

@Nsttt Nsttt merged commit d5530c3 into master Feb 24, 2025
10 checks passed
@Nsttt Nsttt deleted the nestor/rolldown branch February 24, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants