Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove upload_file option #44

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat: remove upload_file option #44

merged 1 commit into from
Feb 12, 2025

Conversation

zmzlois
Copy link
Collaborator

@zmzlois zmzlois commented Feb 12, 2025

What's added in this PR?

Remove upload_file and it's related changes in repack and xpack

Screenshots

What's the issues or discussion related to this PR ?

As previously discussed

What are the steps to test this PR?

Documentation update for this PR (if applicable)?

No previous public documentation on this.

(Optional) What's left to be done for this PR?

(Optional) What's the potential risk and how to mitigate it?

(Required) Pre-PR/Merge checklist

  • I have added/updated/opened a PR to documentation to cover this new behavior
  • I have added an explanation of my changes
  • I have written new tests (if applicable)
  • I have tested this locally (standing from a first time user point of view, never touch this app before)
  • I have/will run tests, or ask for help to add test

Copy link

cla-assistant bot commented Feb 12, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Feb 12, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

nx-cloud bot commented Feb 12, 2025

View your CI Pipeline Execution ↗ for commit 97d91f1.

Command Status Duration Result
nx affected -t test ✅ Succeeded 1m 4s View ↗
nx run-many -t build --all --exclude=examples/** ✅ Succeeded 12s View ↗
nx affected -t lint ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-12 07:28:24 UTC

@zmzlois zmzlois self-assigned this Feb 12, 2025
@zmzlois zmzlois merged commit 7c5e545 into master Feb 12, 2025
7 checks passed
@zmzlois zmzlois deleted the lois/remove-upload-file branch February 12, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants