Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/correct websocket origin #18

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Bugfix/correct websocket origin #18

merged 2 commits into from
Oct 31, 2019

Conversation

Yukaii
Copy link
Owner

@Yukaii Yukaii commented Oct 31, 2019

Fix what?

fixes #16

Changes

  • 拔掉 proxy，其實不需要呢
  • 修正 origin 為 app://vscode-ptt
  • 清掉不需要的 runtime dependencies

Screenshots

Screen Shot 2019-11-01 at 12 07 13 AM

又可以用啦！

@Yukaii Yukaii merged commit a70986f into master Oct 31, 2019
@Yukaii Yukaii deleted the bugfix/correct-websocket-origin branch October 31, 2019 16:09
@Yukaii Yukaii mentioned this pull request Oct 31, 2019
Closed
@kevinptt0323
Copy link

更新到 0.8.1 的話，#17 好像也會順便修好

@Yukaii
Copy link
Owner Author

Yukaii commented Oct 31, 2019

噢噢太好了，我有順便跑 npm update，看 lock 是有升上去

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not working
2 participants
@Yukaii @kevinptt0323