Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed computer metrics usage is different #1315

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • Fixed computer metrics usage is different

Evidence

> ./1314.exe computer-metrics -h
Hayabusa v2.14.0 - Dev Build
Yamato Security (/~https://github.com/Yamato-Security/hayabusa - @SecurityYamato)

Usage:
  hayabusa.exe computer-metrics <INPUT> [OPTIONS]
...

@hitenkoku hitenkoku added the invalid This doesn't seem right label Mar 17, 2024
@hitenkoku hitenkoku self-assigned this Mar 17, 2024
@hitenkoku hitenkoku linked an issue Mar 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (cfb2001) to head (5eef2fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files          27       27           
  Lines       24722    24722           
=======================================
  Hits        20033    20033           
  Misses       4689     4689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku LGTM! Thank you!

@hitenkoku hitenkoku merged commit bfa3750 into main Mar 17, 2024
7 checks passed
@hitenkoku hitenkoku deleted the 1314-computer-metrics-usage-is-different branch March 17, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

computer-metrics usage is different
2 participants