Add bxt_play_folder #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
requested changes
Nov 3, 2022
| path.file_stem() | ||
| .and_then(OsStr::to_str) | ||
| .filter(|name| name.starts_with(&name_prefix)) | ||
| .and_then(|name| name[name_prefix.len()..].parse::<usize>().ok()) |
There was a problem hiding this comment.
Please don't add it into this function. The expression is already way too complicated, the last thing it needs is more special cases. Even just writing out a separate function with the same functionality would be better.
There was a problem hiding this comment.
The find_demos() now has one for folder as requested 👍 I still have play_folder depending on play_run as it would be easier to maintain, I think.
Too lazy to split into commits... Also this really needs lifting the 15 character limitation, I will do that in another commit.
|
Thanks! I'll deal with the filename limitation later because I'll need to check what the engine functions do again for that. For now I think it's decent enough, if you rename the folder to a single letter, you have 13 letters left for demo names. |
|
🐐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"wildcard" is not really wildcard as it won't attempt to match things like what it should, more meant for folder.
enumerate()pretty much does nothing but I think it is better to keep it there to log something for the tuple.