Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Fix GitHubError / InvalidUri(InvalidFormat) #320

Merged
merged 2 commits into from
Mar 31, 2023
Merged

api: Fix GitHubError / InvalidUri(InvalidFormat) #320

merged 2 commits into from
Mar 31, 2023

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Mar 31, 2023

This fixes a symbol name and a bug:

thread panicked at 'called `Result::unwrap()` on an `Err` value: GitHubError(Uri { source: InvalidUri(InvalidFormat), backtrace: Backtrace(   0: <snafu::backtrace_shim::Backtrace as snafu::GenerateImplicitDat
a>::generate
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/snafu-0.7.4/src/backtrace_shim.rs:15:19
      snafu::GenerateImplicitData::generate_with_source
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/snafu-0.7.4/src/lib.rs:1152:9
   1: <octocrab::error::UriSnafu as snafu::IntoError<octocrab::error::Error>>::into_error
             at /root/.cargo/git/checkouts/octocrab-800d493a1be2acf4/50f3f8f/src/error.rs:23:10
   2: <core::result::Result<T,E> as snafu::ResultExt<T,E>>::context
             at /root/.cargo/registry/src/github.com-1ecc6299db9ec823/snafu-0.7.4/src/lib.rs:697:31
   3: octocrab::Octocrab::parameterized_uri
             at /root/.cargo/git/checkouts/octocrab-800d493a1be2acf4/50f3f8f/src/lib.rs:1103:19
   4: octocrab::Octocrab::get_with_headers::{{closure}}
             at /root/.cargo/git/checkouts/octocrab-800d493a1be2acf4/50f3f8f/src/lib.rs:1126:32
   5: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /build/rustc-Oic09u/rustc-1.65.0+dfsg0ubuntu1/library/core/src/future/mod.rs:91:19
   6: octocrab::Octocrab::get::{{closure}}
             at /root/.cargo/git/checkouts/octocrab-800d493a1be2acf4/50f3f8f/src/lib.rs:1073:55
   7: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /build/rustc-Oic09u/rustc-1.65.0+dfsg0ubuntu1/library/core/src/future/mod.rs:91:19
   8: octocrab::api::issues::ListCommentsBuilder::send::{{closure}}
             at /root/.cargo/git/checkouts/octocrab-800d493a1be2acf4/50f3f8f/src/api/issues.rs:716:50

@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit ffbd1c3 into XAMPPRocky:master Mar 31, 2023
@maflcko maflcko deleted the 2303-api-fix- branch March 31, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants