Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

AppArmor, SELinux, Pi detection, Bionic support #227

Merged
merged 6 commits into from
Oct 2, 2019

Conversation

a-martynovich
Copy link
Contributor

@a-martynovich a-martynovich commented Sep 27, 2019

Closes #226
Closes #224
Closes #211
Requires WoTTsecurity/api#426

@vpetersson vpetersson requested a review from rptrchv September 28, 2019 11:27
@a-martynovich a-martynovich changed the title AppArmor, SELinux, Pi detection AppArmor, SELinux, Pi detection, Bionic support Sep 30, 2019
@rptrchv
Copy link
Contributor

rptrchv commented Oct 1, 2019

@a-martynovich and pls fix the Codacy warning

@a-martynovich
Copy link
Contributor Author

@rptrchv Does it make sense to you? To me it doesn't. If I remove self from there it will be impossible to call this method on an instance (is_file() takes 0 positional arguments but 1 was given).
image

@rptrchv
Copy link
Contributor

rptrchv commented Oct 1, 2019

@rptrchv Does it make sense to you? To me it doesn't.

I've already put this exact pylint check to the skip-list in my recent task. Don't do anything re this. I wrote my comment here without looking into the error

@a-martynovich a-martynovich requested a review from rptrchv October 1, 2019 16:31
@vpetersson vpetersson merged commit ce225fd into WoTTsecurity:master Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Pi detection Check AppArmor and SELinux status in Snap Add support for Ubuntu 18.04 (Bionic)
3 participants