fix: crash when moving to scratchpad tiled window #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillPower3309
approved these changes
Jul 19, 2023
WillPower3309
pushed a commit
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #171 swayfx started segfaulting on me when moving a tiled window to the scratchpad. After taking a look at the code, I decided it was better if we didn't render a container that was going away to the scratchpad anyway, therefore also avoiding the NULL-dereferencing that was happening inside
gaps_to_edge()that led to the segfault.If you want to reproduce the bug that is currently present in master, you can try just moving a tiled window to the scratchpad. It isn't always triggered, but the possibility that it is triggered increases the more windows you have open in your workspace.
I've tested this PR on my machines, so far so good.