Moi v0.10 #285
Merged
Moi v0.10 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
@hakank do you mind testing this on your problems before I merge it to master? |
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 97.57% 97.56% -0.02%
==========================================
Files 54 54
Lines 4545 4554 +9
==========================================
+ Hits 4435 4443 +8
- Misses 110 111 +1
Continue to review full report at Codecov.
|
|
I've just tested all my 119 models with this branch and found no new issue. |
|
Thanks for testing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some weird bugs still appear when having double negation with xor.
As an example
@constraint(m, !(!(sum(x) > 3) ⊻ (sum(x) >= 2)))this currently fails to produce the right results