wf-background: allow seamless background updates #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammen99
requested changes
Dec 4, 2023
lcolitti
force-pushed
the
seamless-background-update
branch
2 times, most recently
from
e342815 to
7aa867d
Compare
lcolitti
force-pushed
the
seamless-background-update
branch
from
7aa867d to
934e33c
Compare
soreau
requested changes
Dec 6, 2023
lcolitti
force-pushed
the
seamless-background-update
branch
from
934e33c to
1bec678
Compare
soreau
requested changes
Dec 7, 2023
soreau
reviewed
Dec 7, 2023
Among other things, this allows disabling fading, by setting the fade duration to zero.
lcolitti
force-pushed
the
seamless-background-update
branch
from
1bec678 to
886a6d9
Compare
|
@soreau I think the comment you had was already resolved in the most recent push. Could you take another look? |
soreau
approved these changes
Feb 13, 2024
|
Thanks again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two minor features to wf-background:
Together, these can be allowed to implement seamless background
updates of slow-moving scenes. As an example, my background is an
image recalculated by xplanet every few minutes. I run xplanet
with a post_command that sends a SIGHUP to wf-background.
With a fade duration of zero, wf-background just replaces the
image imperceptibly, with no fading and no flicker.