Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code generation using MatWrapper instead of Mat #942

Merged

Conversation

SamCarlberg
Copy link
Member

Code generation tests obviously need work, but this is the fix for now

@SamCarlberg SamCarlberg added location: codegen type: bugfix Fixes one or more open bugs labels Apr 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #942 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #942      +/-   ##
============================================
- Coverage     52.89%   52.88%   -0.01%     
  Complexity        1        1              
============================================
  Files           327      327              
  Lines          8852     8855       +3     
  Branches        560      561       +1     
============================================
+ Hits           4682     4683       +1     
- Misses         3966     3968       +2     
  Partials        204      204

Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't there tests for this?

@SamCarlberg SamCarlberg added this to the v1.6.0 milestone May 16, 2019
@SamCarlberg SamCarlberg merged commit 4a6c620 into WPIRoboticsProjects:master May 16, 2019
@SamCarlberg SamCarlberg deleted the fix/codegen-wrong-type branch May 16, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
location: codegen type: bugfix Fixes one or more open bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants