Add better support for command line arguments #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 53.67% (diff: 43.68%)@@ master #702 diff @@
==========================================
Files 223 225 +2
Lines 7234 7316 +82
Methods 0 0
Messages 0 0
Branches 712 719 +7
==========================================
+ Hits 3881 3927 +46
- Misses 3180 3216 +36
Partials 173 173
|
SamCarlberg
commented
Nov 4, 2016
| } | ||
| } | ||
|
|
||
| // This will thrown an exception if the port specified by the save file is already taken. |
There was a problem hiding this comment.
"thrown" should be "throw"
Update comment in core main
SamCarlberg
force-pushed
the
fix/server-port-taken
branch
from
51a667d to
d7f9e6b
Compare
|
Did you try this in a deployed application? |
|
If by "deployed" you mean "core app", yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the save file with
-f <path>or--file <path>Set the HTTP server port with
-p <port>or--port <port>Print the version with
-vor--versionPrint help text with
-hor--helpSet headless mode with
--headless(UI only)Can pass command line args through gradle with
-Pargs="<args>"Note: this breaks backwards compatibility with loading files from the command line.