Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webcam sources failing to stop when opening saved projects #686

Merged

Conversation

SamCarlberg
Copy link
Member

Closes #683

@SamCarlberg SamCarlberg added this to the v1.5.0 milestone Oct 12, 2016
@SamCarlberg SamCarlberg self-assigned this Oct 12, 2016
@JLLeitschuh
Copy link
Member

I remember having a debate with Tom about this. I think that's what I had originally but he convinced me to move it out.
Can you leave a comment regarding why using this vs the other one causes this deadlock.

@codecov-io
Copy link

codecov-io commented Oct 12, 2016

Current coverage is 54.51% (diff: 0.00%)

Merging #686 into master will decrease coverage by 0.04%

@@             master       #686   diff @@
==========================================
  Files           209        209          
  Lines          6706       6706          
  Methods           0          0          
  Messages          0          0          
  Branches        656        656          
==========================================
- Hits           3659       3656     -3   
- Misses         2878       2880     +2   
- Partials        169        170     +1   

Sunburst

Powered by Codecov. Last update 7f1498c...6a12ac0

@SamCarlberg
Copy link
Member Author

Code comment or GitHub comment?

@JLLeitschuh
Copy link
Member

Comment in the code.

Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works! Cool thanks!

@JLLeitschuh
Copy link
Member

JLLeitschuh commented Oct 12, 2016

@SamCarlberg SamCarlberg merged commit 103b8a8 into WPIRoboticsProjects:master Oct 12, 2016
@SamCarlberg SamCarlberg deleted the fix/camera-service-failing branch October 12, 2016 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants