Osulacam minimize steps #659
Conversation
…y hides the sockets with a view.
…into MinimizeSteps
This should give me a better idea of why it is failing on Travis and AppVeyor.
…ation on why it fails on Travis and AppVeyor.
… osulacam-MinimizeSteps
| @@ -82,9 +103,21 @@ private void initialize() { | |||
| new Image(InputStream.class.cast(icon)))); | |||
| buttons.getChildren().add(0, exceptionWitnessResponderButtonFactory.create(step, "Step Error")); | |||
|
|
|||
| if (step.getInputSockets().stream() | |||
| .allMatch(inputSocket -> inputSocket.getSocketHint().getView() | |||
| .equals(SocketHint.View.NONE))) { | |||
There was a problem hiding this comment.
I don't think this logic holds true. Does it?
There was a problem hiding this comment.
This is saying if there is no user interaction in this step do not show the arrow
There was a problem hiding this comment.
For example:
Desaturate does not allow for user interaction - no arrow is shown. Filter Contours does -- the arrow is shown.
Current coverage is 58.03% (diff: 85.93%)@@ master #659 diff @@
==========================================
Files 195 196 +1
Lines 6101 6165 +64
Methods 0 0
Messages 0 0
Branches 554 561 +7
==========================================
+ Hits 3517 3578 +61
- Misses 2420 2424 +4
+ Partials 164 163 -1
|
AustinShalit
added
ready for review
in progress
and removed
in progress
ready for review
labels
|
I added the ability to double click the arrow. On a double click it will toggle all steps. |
AustinShalit
force-pushed
the
osulacam-MinimizeSteps
branch
from
c8857b6 to
eb1b013
Compare
| @@ -0,0 +1,14 @@ | |||
| package edu.wpi.grip.ui.events; | |||
|
|
|||
| public class SetStepsExpandedEvent { | |||
AustinShalit
force-pushed
the
osulacam-MinimizeSteps
branch
from
eb1b013 to
8ebaf29
Compare
| @Inject | ||
| StepController(Pipeline pipeline, | ||
| InputSocketControllerFactory inputSocketControllerFactory, | ||
| OutputSocketController.Factory outputSocketControllerFactory, | ||
| ExceptionWitnessResponderButton.Factory exceptionWitnessResponderButtonFactory, | ||
| StepDragService stepDragService, | ||
| @Assisted EventBus eventBus, |
There was a problem hiding this comment.
Why is this assisted? This doesn't need to be assisted.
AustinShalit
force-pushed
the
osulacam-MinimizeSteps
branch
2 times, most recently
from
b1cad27 to
a93b0fb
Compare
| @Subscribe | ||
| public void setExpanded(SetStepsExpandedEvent event) { | ||
| expanded.set(event.isExpanded()); | ||
| } |
There was a problem hiding this comment.
Strange way that this is written. But sure.
Maybe document that a double click will expand all.
There was a problem hiding this comment.
Why do you think it is strange?
There was a problem hiding this comment.
How would you write it?
AustinShalit
force-pushed
the
osulacam-MinimizeSteps
branch
from
a93b0fb to
5b1e389
Compare
closes #327
closes #639
Fix-up of #639