Mac keyboard shortcuts now use command #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 65.25%
@@ master #598 diff @@
==========================================
Files 174 174
Lines 5398 5398
Methods 0 0
Messages 0 0
Branches 517 517
==========================================
+ Hits 3517 3522 +5
+ Misses 1881 1876 -5
Partials 0 0
|
AustinShalit
force-pushed
the
MacKeyboardShortcuts
branch
from
5aeb89c to
75022c3
Compare
|
Can you explain why this works this way? What up vs down does? |
|
Up means that button is up (not pressed). Down means it's pressed |
|
Yup. Just like @SamCarlberg said. Control is the control key but the shortcut modifier is used to represent the modifier key which is used commonly in keyboard shortcuts on the host platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac keyboard shortcuts used control before. Now they use command. Windows still uses control.
Tested on OS X 10.11.5 and Window 10.