fix negative CellVolumes for grids from 3D simplexgrid constructor #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 73.01% 73.66% +0.65%
==========================================
Files 27 32 +5
Lines 4239 4879 +640
==========================================
+ Hits 3095 3594 +499
- Misses 1144 1285 +141 ☔ View full report in Codecov by Sentry. |
j-fu
approved these changes
Jul 17, 2024
|
Is this ready ? I could make the patch release tonight (want to have #55). |
|
Yes, it is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by permutation of cellnodes in 3D simplexgrid constructor. Now CellVolumes are all positive and respective tests were added. The test with the sha_code had to be updated.
Don't confuse with issue #14, which was for tensorized 3D grids. This one here is for direct 3D simplexgrids.