Fix clang 15,16 compilation errors on all platforms, refactor CMake build system #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markos
changed the title
markos
changed the title
In single.cpp featuremask with AVX512 features is not relevant to non-x86 platforms, and just extends the runtime for no reason.
markos
changed the title
markos
changed the title
This was referenced Oct 10, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR as the previous one carried some old cruft.
This should fix builds on clang 15+, plus a missed ragel bug that for some reason appeared only on MacOS X.
Also reduce runtimes of internal and hyperscan unit tests on debug builds as it was timing out CI.
This lead to a significant refactoring of the old CMake build system. The refactored CMakeLists.txt is more modular, has separate include files per architecture and is much more orthogonal -ie, decisions on supported builds are in a single place and will fail early. It still needs some more attention in particular to the fat builds but it's much better than the previous one. It has also led to fixing a few long standing bugs:
#146
#176
#183
At the same time, it brought up a bug #184, but this is irrelevant to this PR.