fix: 修复外部文件拖拽在firefox浏览器或自定义handler时无法工作 #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firefox浏览器的文件拖拽事件types属性为["application/x-moz-file","Files"] 在代码中使用types[0]="Files"判断是否为文件拖拽,这导致在firefox上无法识别文件拖拽 因为判断了url为空则不执行上传,当使用upload.handler自定义上传处理函数,文件拖拽无法正常工作.
Vanessa219
reviewed
Oct 22, 2021
| @@ -1410,7 +1410,7 @@ export const paste = async (vditor: IVditor, event: (ClipboardEvent | DragEvent) | |||
| processPaste(vditor, vditor.lute.HTML2Md(tempElement.innerHTML).trimRight()); | |||
| } | |||
| vditor.outline.render(vditor); | |||
| } else if (files.length > 0 && vditor.options.upload.url) { | |||
| } else if (files.length > 0 && (vditor.options.upload.url||vditor.options.upload.handler)) { | |||
There was a problem hiding this comment.
handler并不需要url配置呀，handler里可以用任意方式上传文件，比如我就是在handler里用angular的httpclient上传文件再把文件地址插入到编辑器中。
izgzhen
pushed a commit
to chafan-dev/vditor
that referenced
this pull request
Dec 11, 2021
firefox浏览器的文件拖拽事件types属性为["application/x-moz-file","Files"] 在代码中使用types[0]="Files"判断是否为文件拖拽,这导致在firefox上无法识别文件拖拽 因为判断了url为空则不执行上传,当使用upload.handler自定义上传处理函数,文件拖拽无法正常工作.
izgzhen
pushed a commit
to chafan-dev/vditor
that referenced
this pull request
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firefox浏览器的文件拖拽事件types属性为["application/x-moz-file","Files"]
在代码中使用types[0]="Files"判断是否为文件拖拽，这导致在firefox上无法识别文件拖拽
因为判断了url为空则不执行传，当使用upload.handler自定义上传处理函数,文件拖拽无法正常工作。