Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GET to access OSRM in place of POST #11

Merged
merged 1 commit into from
Nov 9, 2015

Conversation

frodrigo
Copy link
Contributor

@frodrigo frodrigo commented Nov 7, 2015

Use GET to access OSRM in place of POST, since there is nothing to POST and OSRM 4.8.1 return error on POST to /table

…T and OSRM 4.8.1 return error on POST to /table
@jcoupey
Copy link
Collaborator

jcoupey commented Nov 9, 2015

This was a workaround to avoid long queries being truncated because of length limitations with GET. Related posts for OSRM, see issues 1293 and 1502.

I will check out to the latest 4.8.1 and try to figure out the best way to deal with long queries.

@jcoupey jcoupey merged commit 0181fa3 into VROOM-Project:develop Nov 9, 2015
@jcoupey
Copy link
Collaborator

jcoupey commented Nov 9, 2015

Seriously thinking about using libosrm now...

@frodrigo
Copy link
Contributor Author

frodrigo commented Nov 9, 2015

But, using libosrm force using a local OSRM.

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 9, 2015

I think POST should be ok with table requests on OSRM 4.8.1. From what I get from 1502, the change that broke things for the current osrm_wrapper code is the injection of a ? into the request (clearly visible from osrm-routed output).

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 9, 2015

But, using libosrm force using a local OSRM

Yep, this is the only drawback.

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 9, 2015

Have you tried using a remote OSRM instance with the current code? I would appreciate some feedback on this as I'm always working on the same machine.

@frodrigo
Copy link
Contributor Author

frodrigo commented Nov 9, 2015

I'm only test with remote OSRM

@frodrigo
Copy link
Contributor Author

frodrigo commented Nov 9, 2015

I'm not sure if I understand all the pieces. But a POST request must contains a body. It's not the case with osrm_wrapper, always use the query.

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 9, 2015

Yes, implementing POST queries would really require to do things properly in the wrapper. I'll just let things as they are for now as it is not really a limitation for vroom use.

I'm only test with remote OSRM

Ok thanks, so it is working fine in this setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants