fix(Storybook): fix double scroll in controls panel #8245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8245 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 404 404
Lines 11553 11553
Branches 3836 3836
=======================================
Hits 11037 11037
Misses 516 516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 Docs deployed
Commit 1fbea4c |
inomdzhon
approved these changes
Feb 6, 2025
andrey-medvedev-vk
approved these changes
Feb 6, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/fix-controls-double-scroll
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Feb 6, 2025
| ✅ v7.1.3 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Сейчас на вкладке
Controlsв сторибуке отображается двойной скроллНужно избавиться от двойного скролла
Изменения
Оказалось, чтоб проблема в том, что вкладка
Sourceскрывается только визуально, но остается в верстке. А в стилях сторибука важные стили применяются только к первому элементу.Получается есть два варианта решения проблемы:
SourceпослеControlsSource, если вкладка неактивнаРешил выбрать второй вариант, чтобы не менять порядок вкладок.
Результат:
Release notes
Документация
Controls