Allow feed/flavor assignment in devices view & cleanups/fixes #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-ordering columns - Setting default order - Remove red color unless it signals a problem - Allow to invalidate saved state in case the data table structure / config changed - Formatting of rollout created_at date
b-rowan
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Just a small question about this -
stateLoadParams: (settings, data) => {
// if save state is older than last breaking code change...
if (data.time <= 1722434386000) {
// ... delete it
for (const key of Object.keys(data)) {
delete data[key];
}
}
},This is just a form of cache busting right? Keeps the table state from becoming invalid?
Do we maybe want to move the timestamp from there to a constant stored in another js file then included, which could then be referenced? Something like LAST_TABLE_BREAKING_CHANGE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should wrap up the initial rollout functionality: devices can be assigned to feeds/flavors, and the rollout selection got fixed. UI got cleaned-up to make it easier to use.
Also contains cleanups and bug fixes.
The one thing missing around rollouts is the automatic abort (pause) which will follow in a later PR.