-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immediate device updates & limit attributes to be updated #34
Merged
tsagadar
merged 8 commits into
UpstreamDataInc:master
from
husqvarnagroup:mm/issue-with-assigned-updates
Jul 29, 2024
Merged
Immediate device updates & limit attributes to be updated #34
tsagadar
merged 8 commits into
UpstreamDataInc:master
from
husqvarnagroup:mm/issue-with-assigned-updates
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpdateManager update_xyz methods will immediately persist state to database. Prevents device in-memory state to diverge from database state. Also validated that only UpdateManager updates device state. Explicitly listing attributes to be updated allows to more easily match Tortoise ORM debug logs to the updates that took place. Could help to pinpoint the issue with the assigned firmware being overwritten - or even fix it.
b-rowan
reviewed
Jul 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things to confirm.
Detail message "jwk.py:58: DeprecationWarning: Please use a Key object instead of bytes or string."
This extends the test coverage and no longer relies on internals (db state) to validate state changes.
b-rowan
approved these changes
Jul 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge if you're happy with everything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating the issue, that sometimes an assigned firmware got reset. It showed to be a combination of active UI and device polling. The Tortoise ORM logs were not that helpful as device updates always updated all attributes.
Refactored the code that it explicitly lists what should be updated - and does so immediately after modifying the device state. This either fixed the above issue or at least will help to more easily track it in the future.