Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select target firmware based on device state #148

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Select target firmware based on device state #148

merged 1 commit into from
Oct 2, 2024

Conversation

b-rowan
Copy link
Contributor

@b-rowan b-rowan commented Sep 30, 2024 •
edited by easybe
Loading

Fixes: #146

@easybe
Copy link
Collaborator

easybe commented Oct 1, 2024

The # is missing in the commit message.

tsagadar
tsagadar approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@tsagadar tsagadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I hope to find the time soon to increase test coverage (also including the /bff parts) so that for such changes we also could easily add an additional test to prevent future regressions.

@b-rowan b-rowan merged commit 86062dc into master Oct 2, 2024
5 checks passed
@b-rowan b-rowan deleted the dev_target_sw branch October 2, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsagadar tsagadar tsagadar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device's "Target Software" only set when directly assigning software
4 participants
@b-rowan @easybe @tsagadar @UpstreamData