Fix Docker CI workflow #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are triggered by the `PyPI` workflow and not directly by the push of the Git tag, extracting the version from `GITHUB_REF_NAME` won't work. Calling `git describe` instead also allows the workflow to be run manually, which makes things easier in general. Fixes: UpstreamDataInc#118
b-rowan
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are triggered by the
PyPIworkflow and not directly by the push of the Git tag, extracting the version fromGITHUB_REF_NAMEwon't work. Callinggit describeinstead also allows the workflow to be run manually, which makes things easier in general.Fixes: #118