Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't limit Options.logger to Console type #143

Merged
merged 3 commits into from
Aug 10, 2018
Merged

Don't limit Options.logger to Console type #143

merged 3 commits into from
Aug 10, 2018

Conversation

the-ress
Copy link
Contributor

This is a port of DefinitelyTyped/DefinitelyTyped#27911

Changed Options.logger to accept any object implementing the following methods: error, warn, info.

@johnnyreilly johnnyreilly merged commit 5290364 into TypeStrong:master Aug 10, 2018
@johnnyreilly
Copy link
Member

Thanks!

@the-ress
Copy link
Contributor Author

Thanks

@the-ress the-ress deleted the logger-type branch August 10, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-ress @johnnyreilly