This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Update instructions and appVersion #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeployInBinary
requested review from
a team
and removed request for
DeployInBinary
gothka
suggested changes
Jul 15, 2021
tyk-headless/Chart.yaml
Outdated
| name: tyk-headless | ||
| appVersion: "v3.2.1" |
There was a problem hiding this comment.
IIRC, we've decided to remove appVersion altogether since it can't track all the components.
There was a problem hiding this comment.
I don't about it. where was this decision published? regardless atm it's "1.0" and it's wrong. continue in slack
There was a problem hiding this comment.
I vaguely remember that it was made during our planning session. Maybe @excieve can provide more input on it?
As mentioned on slack, I'm inclined to remove appVersion in the Chart.yaml for all charts.
|
@abhishiekgowtham please resolve the comment if you see fit :) and review from the top. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mongo: {}in tyk-pro/values.yaml since it's confusing. If you set the mongoURL because of the few comment lines you don't see that there're{}aftermongothat needs to be deleted. Adding a single field with the default value sort this out