Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap the version of dask in test environment creation #72

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

acwooding
Copy link
Collaborator

@acwooding acwooding commented Jan 21, 2025

The latest version of dask (2025.0.1) is not compatible with datashader (see below). Cap the version of dask in the test-requirements.txt for now.

datamapplot/__init__.py:1: in <module>
    from datamapplot.create_plots import create_plot, create_interactive_plot
datamapplot/create_plots.py:15: in <module>
    from datamapplot.plot_rendering import render_plot
datamapplot/plot_rendering.py:4: in <module>
    import datashader as ds
../../../hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/datashader/__init__.py:14: in <module>
    from . import data_libraries                             # noqa (API import)
../../../hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/datashader/data_libraries/__init__.py:5: in <module>
    from . import dask    # noqa (API import)
../../../hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/datashader/data_libraries/dask.py:55: in <module>
    bypixel.pipeline.register(dd.core.DataFrame)(dask_pipeline)
E   AttributeError: module 'dask.dataframe.core' has no attribute 'DataFrame'

@acwooding acwooding changed the title Debugging CI environment creation Cap the version of dask in test environment creation Jan 21, 2025
@acwooding acwooding marked this pull request as ready for review January 21, 2025 15:36
@acwooding acwooding requested a review from lmcinnes January 21, 2025 15:36
@lmcinnes lmcinnes merged commit 5ddb656 into TutteInstitute:main Jan 21, 2025
5 checks passed
@lmcinnes
Copy link
Contributor

This is also stopping docs building, so I'll have to take care of that as well I guess. Thanks for this -- it is a little annoying.

@acwooding
Copy link
Collaborator Author

Yeah that's a bit annoying. I suppose that's another reason to add tests to the docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants