Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darkmode on Windows #209

Closed
Avasam opened this issue Apr 8, 2023 · 0 comments · Fixed by #241
Closed

Darkmode on Windows #209

Avasam opened this issue Apr 8, 2023 · 0 comments · Fixed by #241
Labels
enhancement New feature or enhancement request Included in next release UI/UX/Qt Relates to Qt, visuals and user interactions

Comments

@Avasam
Copy link
Collaborator

Avasam commented Apr 8, 2023

Now that Qt6.5 is released, we should be able to natively support dark mode on Windows: https://www.qt.io/blog/dark-mode-on-windows-11-with-qt-6.5#the-qt-65-way
@Avasam Avasam mentioned this issue Apr 8, 2023
Merged
@Avasam Avasam added enhancement New feature or enhancement request UI/UX/Qt Relates to Qt, visuals and user interactions labels Apr 21, 2023
Avasam added a commit that referenced this issue Apr 21, 2023
@Avasam
Drop PyQt6 in favor of PySide6 (#204)
5d1361d 
We already have to install PySide for its tooling anyway. With this we would use the official bindings with a public bug tracker. The size of the bundle is also reduced by ~10MB.

I was also able to remove a hack for the shortcutContext breaking the UI generation tool
Unblocks #209
@Avasam Avasam mentioned this issue Apr 22, 2023
Merged
Avasam added a commit that referenced this issue Apr 22, 2023
@Avasam
Respect the system's palette on Windows (darkmode) (#214)
b8e31de 
Closes #209

It even changes live without having to reboot autosplit. I can also remove a UI hack for Windows 11.
The red and orange outlines are because I set my accent color to red and orange in Windows 10 and 11 respectively.

Windows 10 fusion light
![image](https://user-images.githubusercontent.com/1350584/233756850-30a24bab-a4a9-48be-8f21-5cba2fe719ec.png)

Windows 10 fusion dark
![image](https://user-images.githubusercontent.com/1350584/233756893-d665f778-6526-42a9-83a0-3f94884b74aa.png)

Windows 11 fusion light
![f5312fc2-a522-441a-b86a-8fb339fdbd86](https://user-images.githubusercontent.com/1350584/233757216-c96325f9-0f03-49a8-adae-707010142c70.jpg)

Windows 11 fusion dark
![34ad4a33-f077-42b8-986f-3d33c6b761af](https://user-images.githubusercontent.com/1350584/233757219-7562c879-8704-4cb8-be35-a6c2ae18a270.jpg)
@Avasam Avasam pinned this issue Apr 27, 2023
@Avasam Avasam mentioned this issue May 25, 2023
Merged
@Avasam Avasam unpinned this issue Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or enhancement request Included in next release UI/UX/Qt Relates to Qt, visuals and user interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge Dev to Master Toufool/AutoSplit
1 participant
@Avasam