Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(deps): hyper 1.0 #126

Merged
merged 41 commits into from
Nov 2, 2023
Merged

Chore(deps): hyper 1.0 #126

merged 41 commits into from
Nov 2, 2023

Conversation

Totodore
Copy link
Owner

@Totodore Totodore commented Oct 23, 2023

Migrate to hyper 1.0

This migration should be opt-in through a feature flag. It would add :

  • A hyper::service::Service to the EngineIoService struct with an hyper::body::Incoming input type
  • A hyper::service::Service to the SocketIoService struct with an hyper::body::Incoming input type
  • A build_server() on the SocketIoBuilder to directly spawn a server, because from 1.0 hyper is dropign its Server struct in favour of manual implementation with a TcpListener
  • Change the body type from http-body 0.4 to http-body 1.0

@Totodore Totodore linked an issue Oct 23, 2023 that may be closed by this pull request
@Totodore Totodore self-assigned this Oct 23, 2023
@Totodore
Copy link
Owner Author

Currently stuck because of salvo-rs/salvo#468

@Totodore Totodore marked this pull request as ready for review November 2, 2023 11:06
@Totodore Totodore merged commit 132bd07 into main Nov 2, 2023
11 checks passed
@Totodore Totodore deleted the chore(deps)-hyper-1.0 branch November 2, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Tracking issue: hyper v1.0 support
2 participants