Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual 7z. #44

Merged
merged 11 commits into from
Oct 29, 2023
Merged

Add manual 7z. #44

merged 11 commits into from
Oct 29, 2023

Conversation

HolographicWings
Copy link
Contributor

That would be interesting to add a manual way to 7z releases instead of zip, especially when the 7z releases are 3x smaller.
I'm unsure if theses changes are correct, Shell is not my thing.
Do i have anything to fix ?

HolographicWings and others added 2 commits May 25, 2023 23:07
Unsure about what i'm doing
@vasilvestre
Copy link
Contributor

I added to documentation the 7z type @HolographicWings

@HolographicWings
Copy link
Contributor Author

HolographicWings commented May 28, 2023

oh sorry for the multiple commits, i forgot the PR and did some tests to fix an issue with my first commit.
councider this PR as draft

@HolographicWings
Copy link
Contributor Author

HolographicWings commented May 28, 2023

Well, that definitely don't work, the 7z creation work fine but the exclusions just don't work
I can't figure out how to fix that, i tried everything
For 7z, each exclusion must begin by -x!
for EXCLUSION in $INPUT_EXCLUSIONS don't split the exclusions from a long string to an array
to made the 7z exclusions work, spliting them on every spaces is required

@TheDoctor0
Copy link
Owner

Hey @HolographicWings!
First and foremost thank you for this contribution.
I considered using 7z initially instead of zip but the problem was that it was not available on Windows, so it did not fit the cross-platform availability requirement. That said, right now I don't see any harm in adding it as an alternative.

for EXCLUSION in $INPUT_EXCLUSIONS don't split the exclusions from a long string to an array
to made the 7z exclusions work, spliting them on every spaces is required

Actually, it for EXCLUSION in $INPUT_EXCLUSIONS does exactly that as Bash splits the string into words and skips the spaces between them when using a for loop.

@vasilvestre
Copy link
Contributor

Hey @HolographicWings! First and foremost thank you for this contribution. I considered using 7z initially instead of zip but the problem was that it was not available on Windows, so it did not fit the cross-platform availability requirement. That said, right now I don't see any harm in adding it as an alternative.

for EXCLUSION in $INPUT_EXCLUSIONS don't split the exclusions from a long string to an array
to made the 7z exclusions work, spliting them on every spaces is required

Actually, it for EXCLUSION in $INPUT_EXCLUSIONS does exactly that as Bash splits the string into words and skips the spaces between them when using a for loop.

FYI we managed to make zip and 7z, see here : /~https://github.com/HolographicWings/TOTK-Mods-collection/blob/main/.github/workflows/release.yml#L19

@God-damnit-all
Copy link

Hey @HolographicWings! First and foremost thank you for this contribution. I considered using 7z initially instead of zip but the problem was that it was not available on Windows, so it did not fit the cross-platform availability requirement. That said, right now I don't see any harm in adding it as an alternative.

for EXCLUSION in $INPUT_EXCLUSIONS don't split the exclusions from a long string to an array
to made the 7z exclusions work, spliting them on every spaces is required

Actually, it for EXCLUSION in $INPUT_EXCLUSIONS does exactly that as Bash splits the string into words and skips the spaces between them when using a for loop.

Windows 11 is officlally adding support for every (unencrypted) archive supported by libarchive in an upcoming build: https://blogs.windows.com/windows-insider/2023/08/18/announcing-windows-11-insider-preview-build-22621-2199-and-22631-2199-beta-channel/

@TheDoctor0 TheDoctor0 merged commit 51801f7 into TheDoctor0:main Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants