Linting work to achieve a Go Report Card A+ #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mega linting pkg is extremely hard on the system shooting up
loads and memory consumption, therefore it is best to split
them up and drop the concurrency level on pkg when the crypto
tests fire off.
-cmd/gompw/flags.go:136::warning: declaration of "err" shadows declaration at cmd/gompw/flags.go:40 (vetshadow) -cmd/gompw/flags.go:139::warning: declaration of "err" shadows declaration at cmd/gompw/flags.go:40 (vetshadow) -cmd/gompw/flags.go:150::warning: declaration of "err" shadows declaration at cmd/gompw/flags.go:40 (vetshadow) -cmd/gompw/flags.go:160::warning: declaration of "err" shadows declaration at cmd/gompw/flags.go:40 (vetshadow)
-cmd/gompw/main.go:33:12:warning: should omit type string from declaration of var PROG; it will be inferred from the right-hand side (golint) -cmd/gompw/main.go:33:2:warning: exported var PROG should have comment or be unexported (golint) -cmd/gompw/main.go:35:12:warning: should omit type string from declaration of var BUILD; it will be inferred from the right-hand side (golint)
…the main pkg -cmd/gompw/main.go:43:6:warning: exported type MPW should have comment or be unexported (golint)
-cmd/gompw/utils.go:33:2:warning: don't use ALL_CAPS in Go names; use CamelCase (golint) -cmd/gompw/utils.go:33:2:warning: exported var MP_DEBUG should have comment or be unexported (golint) -cmd/gompw/utils.go:36:1:warning: exported function DEBUG should have comment or be unexported (golint)
… the system Also includes the 'pkg' cyclomatic adjustments
-pkg/crypto/masterPassword.go:106:14:warning: error return value not checked (binary.Write(&buffer, binary.BigEndian, uint32(len(mpw.fullname)))) (errcheck) -pkg/crypto/masterPassword.go:132:14:warning: error return value not checked (binary.Write(&buffer, binary.BigEndian, uint32(len(mpw.site)))) (errcheck) -pkg/crypto/masterPassword.go:134:14:warning: error return value not checked (binary.Write(&buffer, binary.BigEndian, mpw.counter)) (errcheck) -pkg/crypto/masterPassword.go:139:13:warning: error return value not checked (hmacv.Write(buffer.Bytes())) (errcheck)
-pkg/crypto/masterPassword_test.go:117::warning: duplicate of pkg/crypto/masterPassword_test.go:128-138 (dupl) -pkg/crypto/masterPassword_test.go:128::warning: duplicate of pkg/crypto/masterPassword_test.go:139-149 (dupl) -pkg/crypto/masterPassword_test.go:139::warning: duplicate of pkg/crypto/masterPassword_test.go:174-184 (dupl) -pkg/crypto/masterPassword_test.go:174::warning: duplicate of pkg/crypto/masterPassword_test.go:117-127 (dupl)
-pkg/crypto/passwordPurpose.go:29:7:warning: exported const DefaultPasswordPurpose should have comment or be unexported (golint) -pkg/crypto/passwordPurpose.go:32:2:warning: exported const PasswordPurposeUnSet should have comment (or a comment on this block) or be unexported (golint) -pkg/crypto/passwordPurpose.go:39:2:warning: exported var ErrPasswordPurposeEmpty should have comment or be unexported (golint)
-pkg/debug/debug.go:36:2:warning: exported var D should have comment or be unexported (golint) -pkg/debug/debug.go:37:2:warning: don't use ALL_CAPS in Go names; use CamelCase (golint) -pkg/debug/debug.go:40:6:warning: exported type Debug should have comment or be unexported (golint)
-pkg/debug/debug.go:33:6:warning: exported type Debug should have comment or be unexported (golint) -pkg/debug/debug.go:47:1:warning: exported function NewDebug should have comment or be unexported (golint) -pkg/debug/debug.go:58:1:warning: exported method Debug.Dbg should have comment or be unexported (golint) -pkg/debug/debug.go:75:1:warning: exported method Debug.DbgO should have comment or be unexported (golint) -pkg/debug/debug.go:79:1:warning: exported method Debug.SetFilename should have comment or be unexported (golint)
TerraTech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Underlying tool was using gometalinter.