Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 다운로드 버튼 기능 업데이트 #305

Merged
merged 17 commits into from
Nov 25, 2022
Merged

[Feat] 다운로드 버튼 기능 업데이트 #305

merged 17 commits into from
Nov 25, 2022

Conversation

JMM00
Copy link
Member

@JMM00 JMM00 commented Nov 25, 2022 •
edited
Loading

관련 이슈

구현/변경 사항

  • 이전버전 다운로드 클릭 시 다운로드 숫자 업데이트
  • 최신버전 다운로드 클릭 시 현재 가지고 있는 링크와 비교 후 다르면 유저정보 업데이트
  • 로그아웃 시 유저가 다운로드한 단축어, 유저가 좋아요한 단축어를 추가적으로 초기화하도록 했습니다.

스크린샷

2022-11-25.8.25.54.mov

JMM00 added 15 commits November 24, 2022 16:26
@JMM00
[Feat] #295 - add previous version download number update function
e6e9bcd
@JMM00
wip
85e4800
@JMM00
[Feat] #295 - add download link update function
bbce5b5
@JMM00
[Style] change navigation bar item code location
06219da
@JMM00
[Style] delete button background color
d91e919
@JMM00
[Refactor] #295 - change function execution position
6153095
@JMM00
[Refactor] #295 - change download shortcut update logic
c7e19fc
@JMM00
[Feat] #295 - add previous version download number update function
5305d1d
@JMM00
wip
8bc0edd
@JMM00
[Feat] #295 - add download link update function
2680ee5
@JMM00
[Style] change navigation bar item code location
fcda193
@JMM00
[Style] delete button background color
fce1191
@JMM00
[Refactor] #295 - change function execution position
1a9605a
@JMM00
[Refactor] #295 - change download shortcut update logic
b981137
@JMM00
Merge remote-tracking branch 'refs/remotes/origin/ReadShortcutView/Pr…
abf3067 
…eviousVersionDownload'
@JMM00 JMM00 added the Type-Feature New feature label Nov 25, 2022
@JMM00 JMM00 added this to the 3rd Sprint milestone Nov 25, 2022
@JMM00 JMM00 self-assigned this Nov 25, 2022
JIWON1923
JIWON1923 approved these changes Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@JIWON1923 JIWON1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! iOS 16 실기기 테스트 확인했습니다◡̈
고생하셨어요 엘뤼~!~!

HanGyeongjun
HanGyeongjun approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@HanGyeongjun HanGyeongjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정상 작동 확인했습니다! 수고하셨어요 👍🏻

HappyAnding/HappyAnding/ViewModel/ShortcutsZipViewModel.swift
Comment on lines +578 to +579
self.shortcutsUserDownloaded.removeAll()
self.shortcutsUserLiked.removeAll()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

삭제까지 꼼꼼하게 구현해주셨네요!

@JMM00 JMM00 merged commit c4b572a into develop Nov 25, 2022
@JMM00 JMM00 deleted the ReadShortcutView/PreviousVersionDownload branch November 25, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JIWON1923 JIWON1923 JIWON1923 approved these changes

@HanGyeongjun HanGyeongjun HanGyeongjun approved these changes

@jim4020key jim4020key Awaiting requested review from jim4020key

@otoolz otoolz Awaiting requested review from otoolz

@mxnxxii mxnxxii Awaiting requested review from mxnxxii

Assignees

@JMM00 JMM00

Labels
Type-Feature New feature
Projects
None yet
Milestone
3rd Sprint
Development

Successfully merging this pull request may close these issues.

[Feat] 단축어 다운로드 시 정보 업데이트 [Feat] 단축어 버전 관련 함수 구현
3 participants
@JMM00 @JIWON1923 @HanGyeongjun