-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unhandledRejectionHandler #3
Conversation
1 similar comment
@Tapppi please enable |
@simonepri I have enabled issues, feel free to propose changes. As for this PR, I like the idea, but can you give your thought process for removing unhandled rejections from the error handler? I am not calling it a bad change, just want to verify the justification as it makes this a major version bump |
Actually, you already gave your justification. I will merge this and release it as a new major version! |
@Tapppi Thank you. |
@simonepri |
@Tapppi the build is failing. |
@simonepri I updated the style of the repository, which caused node v4 to fail tests because of a missing |
Good, currently I'm improving the documentation a bit. |
Unhandled rejections shouldn't be handled in the same callback of uncaught exceptions for 2 main reasons:
This PR solves the problem adding another dedicated handler function